Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should run with container version built from the repo #1243

Closed
andychu opened this issue Jul 21, 2022 · 2 comments
Closed

CI should run with container version built from the repo #1243

andychu opened this issue Jul 21, 2022 · 2 comments
Labels
c-i dev-friction pending-release

Comments

@andychu
Copy link
Contributor

andychu commented Jul 21, 2022

This is far off and would involve "replacing" Docker, but we hit this "in real life"

#1241

i.e. it would be nice if the container BINARIES were versioned with the oilshell/oil git repo.

Although maybe you can already do that in Docker with labels or something? Not sure
@andychu
Copy link
Contributor Author

andychu commented Jul 22, 2022

Another issue with Docker: the registry can be flaky!

https://github.com/oilshell/oil/actions/runs/2715422494

andychu pushed a commit that referenced this issue Aug 5, 2022
[soil] Tag images with a version string
921bd73 
Right now it's v-2022-08-04

And pull these specific images.

Related to #1243.  The version is now in the repo!
@andychu andychu mentioned this issue Aug 6, 2022
Open
@andychu
Copy link
Contributor Author

andychu commented Aug 24, 2022

https://www.oilshell.org/blog/2022/08/release-0.12.4.html

@andychu andychu closed this as completed Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c-i dev-friction pending-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andychu