Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands should be entered in history after history expansion #231

Closed
andychu opened this issue Feb 12, 2019 · 1 comment
Closed

commands should be entered in history after history expansion #231

andychu opened this issue Feb 12, 2019 · 1 comment
Labels
pending-release

Comments

@andychu
Copy link
Contributor

andychu commented Feb 12, 2019

Python's readline binding automatically adds a command like !1039 to the history. We should enter the real command instead, like other shells do.

This requires forking the readline binding, which isn't hard except for build issues.
@andychu andychu mentioned this issue Feb 19, 2019
Open
andychu pushed a commit that referenced this issue Feb 20, 2019
[build] Copy readline module to line_input so we can fork it.
391297e 
This will aid in correct history expansion (#231) as well as completion
on OS X (#228).

Tested:

- dev build with line_input.so
- Building _bin/oil.ovm{,-dbg} in the repo
- tarball build on my machine (build/test.sh)
- tarball build in Alpine Linux, without readline (test/alpine.sh)
@andychu andychu reopened this Feb 20, 2019
@andychu
Copy link
Contributor Author

andychu commented Mar 19, 2019

Fixed with 0.6.pre16

@andychu andychu closed this as completed Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andychu