Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues uncovered by toysh blog test cases #780

Open
3 of 5 tasks
andychu opened this issue Jun 26, 2020 · 0 comments
Open
3 of 5 tasks

issues uncovered by toysh blog test cases #780

andychu opened this issue Jun 26, 2020 · 0 comments

Comments

@andychu
Copy link
Contributor

andychu commented Jun 26, 2020

Divergences:

  • evaluation order of >bad echo {undef?err}
  • $((echo hello)) somehow parses but it shouldn't
  • two failing IFS test cases in spec/toysh (these cases found bugs in yash!)

Not implemented:

  • @Q on arrays -- not implemented (crashes)
  • extended globs of the file system (fnmatch of extended globs is implemented)

Known differences:

@andychu andychu changed the title bugs from toysh suite issues uncovered by toysh blog test cases Jun 26, 2020
andychu pushed a commit that referenced this issue Jun 26, 2020
Basically all 2020 and 2019 cases here: http://landley.net/notes.html

(at least the ones that were formatted nicely)

Related to issue #780.
andychu pushed a commit that referenced this issue Jun 27, 2020
- The ${!prefix@} query was too loose on 2 counts!  Tightened it up
- Fix crash with undefined variable and @A
- Added more spec tests

Addresses one part of #780.
andychu pushed a commit that referenced this issue Jun 27, 2020
We allowed extra tokens everywhere.  See test/parse-errors.sh.

Fixes an issue in #780, e.g. $((a b)) should fail.  Also ((a b)) and
more.

- Failing test case for another parsing problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant