Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename a couple builtins #949

Closed
andychu opened this issue May 19, 2021 · 2 comments
Closed

Rename a couple builtins #949

andychu opened this issue May 19, 2021 · 2 comments
Labels
oil-language pending-release

Comments

@andychu
Copy link
Contributor

andychu commented May 19, 2021

https://oilshell.zulipchat.com/#narrow/stream/121540-oil-discuss/topic/Renaming.20Proposals

  • run -> try
  • push -> append, and then we're going to reuse push for global state (and maybe registers)
andychu pushed a commit that referenced this issue May 20, 2021
[oil_lang/builtins] Rename push -> append
f520121 
- The 'push' name connotes a stack, and the interpreter itself has many
  stacks.
- 'append' will be more consistent with a function append

Addresses issue #949.
@andychu
Copy link
Contributor Author

andychu commented May 20, 2021

Original proposal was "status"

https://oilshell.zulipchat.com/#narrow/stream/121540-oil-discuss/topic/status.20builtin.20proposal

andychu pushed a commit that referenced this issue May 20, 2021
[oil_lang/builtins] Rename run -> try
f14bc79 
Rename --assign-status -> assign

Because --assign :status reads fine.

Addresses issue #949

Update docs.
@andychu
Copy link
Contributor Author

andychu commented Jul 7, 2021

https://www.oilshell.org/blog/2021/07/release-0.8.12.html

@andychu andychu closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
oil-language pending-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andychu