[test] Write exhaustive tests over the bjorn dfa and crockford utf8 decoders #1941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a way to exhaustively test all the interesting cases for our UTF-8 decoder which is only ~9 million byte sequences. My reasoning for that is covered in the header of
data_lang/utf8_test.cc
These tests required some meta-programming so I could avoid lots of manual bit-math. They are generated from bit patterns like
1111 xxxx
which denotes the byte range 0xF0 to 0xFF. This is done using thedata_lang/utf8_decoder_tests_gen.py
script which is invoked at build time.I've been running the tests as so:
ninja _bin/cxx-asan/data_lang/utf8_test ./_bin/cxx-asan/data_lang/utf8_test -t utf8_decoder # or just ./_bin/cxx-asan/data_lang/utf8_test for all tests
They should be run in CI as well.