Warn that :result-type is deprecated.
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a more flexible approach with coercion functions an `accum-opt`. Removal is tracked in #154.
okamsn
force-pushed
the
deprecate-result-type
branch
from
de9f568
to
3146186
Compare
okamsn
added a commit
that referenced
this pull request
Mar 9, 2024
This argument was deprecated in PR #162. See also issue #154. - Remove tests of `:result-type`. - Remove the relevant code. - Update test `acccumulation-conflicting-final-updates` to use custom commands instead of checking using `:result-type`. - Make sure the accumulation category actually gets set when the `:category` argument is passed to `loopy--defaccumulation`.
okamsn
added a commit
that referenced
this pull request
Mar 9, 2024
This argument was deprecated in PR #162. See also issue #154. - Remove tests of `:result-type`. - Remove the relevant code. - Update test `acccumulation-conflicting-final-updates` to use custom commands instead of checking using `:result-type`. - Make sure the accumulation category actually gets set when the `:category` argument is passed to `loopy--defaccumulation`.
okamsn
added a commit
that referenced
this pull request
Mar 9, 2024
This argument was deprecated in PR #162. See also issue #154. - Remove tests of `:result-type`. - Remove the relevant code. - Update test `acccumulation-conflicting-final-updates` to use custom commands instead of checking using `:result-type`. - Make sure the accumulation category actually gets set when the `:category` argument is passed to `loopy--defaccumulation`.
okamsn
added a commit
that referenced
this pull request
Mar 9, 2024
This argument was deprecated in PR #162. See also issue #154. - Remove tests of `:result-type`. - Remove the relevant code. - Update test `acccumulation-conflicting-final-updates` to use custom commands instead of checking using `:result-type`. - Make sure the accumulation category actually gets set when the `:category` argument is passed to `loopy--defaccumulation`. - Remove the keyword from the mostly unused `loopy--accum-common-keywords-edebug-spec` debug specification.
okamsn
added a commit
that referenced
this pull request
Mar 9, 2024
This argument was deprecated in PR #162. See also issue #154. - Remove tests of `:result-type`. - Remove the relevant code. - Update test `acccumulation-conflicting-final-updates` to use custom commands instead of checking using `:result-type`. - Make sure the accumulation category actually gets set when the `:category` argument is passed to `loopy--defaccumulation`. - Remove the keyword from the mostly unused `loopy--accum-common-keywords-edebug-spec` debug specification.
github-actions bot
added a commit
that referenced
this pull request
Mar 9, 2024
#196) This commit was copied from the master branch. Commit: 395885b Author: okamsn <28612288+okamsn@users.noreply.github.com> Date: 2024-03-09 15:51:21 +0000 Remove the deprecated `:result-type` keyword argument. (#196) This argument was deprecated in PR #162. See also issue #154. - Remove tests of `:result-type`. - Remove the relevant code. - Update test `acccumulation-conflicting-final-updates` to use custom commands instead of checking using `:result-type`. - Make sure the accumulation category actually gets set when the `:category` argument is passed to `loopy--defaccumulation`. - Remove the keyword from the mostly unused `loopy--accum-common-keywords-edebug-spec` debug specification.
github-actions bot
added a commit
that referenced
this pull request
Mar 9, 2024
#196) This commit was copied from the master branch. Commit: 395885b Author: okamsn <28612288+okamsn@users.noreply.github.com> Date: 2024-03-09 15:51:21 +0000 Remove the deprecated `:result-type` keyword argument. (#196) This argument was deprecated in PR #162. See also issue #154. - Remove tests of `:result-type`. - Remove the relevant code. - Update test `acccumulation-conflicting-final-updates` to use custom commands instead of checking using `:result-type`. - Make sure the accumulation category actually gets set when the `:category` argument is passed to `loopy--defaccumulation`. - Remove the keyword from the mostly unused `loopy--accum-common-keywords-edebug-spec` debug specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a more flexible approach with coercion functions an
accum-opt.Removal is tracked in #154.