Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated :result-type keyword argument. #196

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

okamsn
Copy link
Owner

@okamsn okamsn commented Mar 9, 2024

This argument was deprecated in PR #162.
See also issue #154.

  • Remove tests of :result-type.
  • Remove the relevant code.
  • Update test acccumulation-conflicting-final-updates to use custom commands
    instead of checking using :result-type.
  • Make sure the accumulation category actually gets set when
    the :category argument is passed to loopy--defaccumulation.

@okamsn okamsn force-pushed the remove-result-type branch 2 times, most recently from 8c24b7d to 5450cb9 Compare March 9, 2024 15:40
This argument was deprecated in PR #162.
See also issue #154.

- Remove tests of `:result-type`.
- Remove the relevant code.
- Update test `acccumulation-conflicting-final-updates` to use custom commands
  instead of checking using `:result-type`.
- Make sure the accumulation category actually gets set when
  the `:category` argument is passed to `loopy--defaccumulation`.
- Remove the keyword from the mostly unused
  `loopy--accum-common-keywords-edebug-spec` debug specification.
@okamsn okamsn merged commit 395885b into master Mar 9, 2024
4 checks passed
github-actions bot added a commit that referenced this pull request Mar 9, 2024
#196)

This commit was copied from the master branch.

Commit: 395885b
Author: okamsn <28612288+okamsn@users.noreply.github.com>
Date: 2024-03-09 15:51:21 +0000

Remove the deprecated `:result-type` keyword argument. (#196)

This argument was deprecated in PR #162.
See also issue #154.

- Remove tests of `:result-type`.
- Remove the relevant code.
- Update test `acccumulation-conflicting-final-updates` to use custom commands
  instead of checking using `:result-type`.
- Make sure the accumulation category actually gets set when
  the `:category` argument is passed to `loopy--defaccumulation`.
- Remove the keyword from the mostly unused
  `loopy--accum-common-keywords-edebug-spec` debug specification.
github-actions bot added a commit that referenced this pull request Mar 9, 2024
#196)

This commit was copied from the master branch.

Commit: 395885b
Author: okamsn <28612288+okamsn@users.noreply.github.com>
Date: 2024-03-09 15:51:21 +0000

Remove the deprecated `:result-type` keyword argument. (#196)

This argument was deprecated in PR #162.
See also issue #154.

- Remove tests of `:result-type`.
- Remove the relevant code.
- Update test `acccumulation-conflicting-final-updates` to use custom commands
  instead of checking using `:result-type`.
- Make sure the accumulation category actually gets set when
  the `:category` argument is passed to `loopy--defaccumulation`.
- Remove the keyword from the mostly unused
  `loopy--accum-common-keywords-edebug-spec` debug specification.
@okamsn okamsn deleted the remove-result-type branch September 14, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant