Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brew formula question #28

Closed
josser opened this issue Oct 3, 2017 · 9 comments
Closed

Brew formula question #28

josser opened this issue Oct 3, 2017 · 9 comments

Comments

@josser
Copy link
Contributor

josser commented Oct 3, 2017

Hi! I've created brew formula for your awesome project but there is one small thing I don't know how to handle.

Brew is a package manager for OS X like portage in gentoo or ports in freebsd.
They have a lot of acceptance criteria and one of them is having a test of application for running after compiling.
For small programs they usually check for --help or --version, but this is not considered as a good practice. Better to have some 'real' cases of application usage.
Also, those tests should be non-interactive so CI can run them

So, I've started to write a formula but it's turned out that I can't write any type of test for your app.
I've checked how they usually test other pagers, i.e vimpager: https://github.com/Homebrew/homebrew-core/blob/93a8200c17986038585a140cce4a9bc93e4a3f86/Formula/vimpager.rb

but this approach is not fit for your pager because it bring up interactive interface even if there is not enough content for paging.
Also, you don't have --version or --help.

So, i've created this #27

I have never write any line of C, but I hope there is nothing wrong with this few lines.
If you accept PR, please, do a release so I can update brew formula with new version (0.3?)

Thank you and sorry if my english is not good )

@okbob
Copy link
Owner

okbob commented Oct 3, 2017

I have not any problem to write --version or --help commands. But it is pretty hard to write non interactive test for pspg.

@okbob
Copy link
Owner

okbob commented Oct 3, 2017

I cleaned your version PR, and I wrote --help option.

@josser
Copy link
Contributor Author

josser commented Oct 3, 2017

Cool! Now, I'm only need 0.3 release because brew prefer specific version to build, not -master or -develop branch.

@okbob
Copy link
Owner

okbob commented Oct 3, 2017 via email

@okbob
Copy link
Owner

okbob commented Oct 3, 2017

there is a v0.3 release

@josser
Copy link
Contributor Author

josser commented Oct 4, 2017

Ok, closing for now, they don't like pre-release software (0.xx version probably)
Will wait for 1.0

@josser josser closed this as completed Oct 4, 2017
@exebece
Copy link

exebece commented Jun 21, 2018

hi guys. Thank both of you ;) I'm really happy that pspg is available that easy way in os x. Excellent package and great effort to make a formula. Thubms up & beer promise sent - next time we meet I owe you ;)

@josser
Copy link
Contributor Author

josser commented Jun 21, 2018

@exebece have to say that I'm not author of current formula because mine hasn't been accepted when I've created it because pspg was in 'beta' that time.
So, all thanks goes to @jasonmp85 :)

@exebece
Copy link

exebece commented Jun 21, 2018

oic but my thanks still goes to all of you :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants