-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brew formula question #28
Comments
I have not any problem to write --version or --help commands. But it is pretty hard to write non interactive test for pspg. |
I cleaned your version PR, and I wrote --help option. |
Cool! Now, I'm only need 0.3 release because brew prefer specific version to build, not -master or -develop branch. |
I would to fix one issue, and then I'll release 0.3
Regards
Pavel
2017-10-03 16:32 GMT+02:00 Dmitry Chirkin <notifications@github.com>:
… Cool! Now, I'm only need 0.3 release because brew prefer specific version
to build, not -master or -develop branch.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#28 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAhXc5Jk3NA9ZHc-MsNPUeak5fh4_3FIks5sokWWgaJpZM4Pr6Z4>
.
|
there is a v0.3 release |
Ok, closing for now, they don't like pre-release software (0.xx version probably) |
hi guys. Thank both of you ;) I'm really happy that pspg is available that easy way in os x. Excellent package and great effort to make a formula. Thubms up & beer promise sent - next time we meet I owe you ;) |
@exebece have to say that I'm not author of current formula because mine hasn't been accepted when I've created it because pspg was in 'beta' that time. |
oic but my thanks still goes to all of you :) |
Hi! I've created brew formula for your awesome project but there is one small thing I don't know how to handle.
Brew is a package manager for OS X like portage in gentoo or ports in freebsd.
They have a lot of acceptance criteria and one of them is having a test of application for running after compiling.
For small programs they usually check for --help or --version, but this is not considered as a good practice. Better to have some 'real' cases of application usage.
Also, those tests should be non-interactive so CI can run them
So, I've started to write a formula but it's turned out that I can't write any type of test for your app.
I've checked how they usually test other pagers, i.e vimpager: https://github.com/Homebrew/homebrew-core/blob/93a8200c17986038585a140cce4a9bc93e4a3f86/Formula/vimpager.rb
but this approach is not fit for your pager because it bring up interactive interface even if there is not enough content for paging.
Also, you don't have --version or --help.
So, i've created this #27
I have never write any line of C, but I hope there is nothing wrong with this few lines.
If you accept PR, please, do a release so I can update brew formula with new version (0.3?)
Thank you and sorry if my english is not good )
The text was updated successfully, but these errors were encountered: