Merge pull request #50 from mic4ael/close-button-type

Prevent ENTER from triggering click events
okcoker · Mar 25, 2016 · 9176e1e · 9176e1e
2 parents fde8ec6 + f762f2c
commit 9176e1e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/taggle.js b/src/taggle.js
@@ -655,6 +655,7 @@
 
         close.innerHTML = '&times;';
         close.className = 'close';
+        close.type = 'button';
         _on(close, 'click', this._remove.bind(this, close));
 
         _setText(span, text);

diff --git a/test/taggle-test.js b/test/taggle-test.js
@@ -640,5 +640,21 @@ describe('Taggle', function() {
                 expect(this.instance.getTagValues().length).to.equal(1);
             });
         });
+
+        describe('#checkCloseButtonType', function() {
+            beforeEach(function() {
+                this.instance = new Taggle(this.container, {
+                    tags: ['zero', 'one', 'two']
+                });
+            });
+
+            it('should have type equal to button', function() {
+                var elements = this.instance.getTagElements();
+                for (var i = 0; i < elements.length; ++i) {
+                    var closeButton = elements[i].querySelector('button.close');
+                    expect(closeButton).to.have.property('type').and.equal('button');
+                }
+            });
+        });
     });
 });