Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent ENTER from triggering click events #50

Merged
merged 1 commit into from
Mar 25, 2016
Merged

Prevent ENTER from triggering click events #50

merged 1 commit into from
Mar 25, 2016

Conversation

mic4ael
Copy link
Contributor

@mic4ael mic4ael commented Mar 24, 2016

Fixes #49

@okcoker
Copy link
Owner

okcoker commented Mar 25, 2016

Where and when does pressing enter make the click event happen?

@okcoker
Copy link
Owner

okcoker commented Mar 25, 2016

Should have looked at #49 first :)

@okcoker
Copy link
Owner

okcoker commented Mar 25, 2016

Can you add a test to make sure this type attribute is there?

@mic4ael
Copy link
Contributor Author

mic4ael commented Mar 25, 2016

Sure, I am gonna do it right away

@mic4ael
Copy link
Contributor Author

mic4ael commented Mar 25, 2016

Done, you can have a look right now and let me know if everything looks fine

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 83.642% when pulling f762f2c on mic4ael:close-button-type into fde8ec6 on okcoker:master.

@okcoker okcoker merged commit 9176e1e into okcoker:master Mar 25, 2016
@okcoker
Copy link
Owner

okcoker commented Mar 25, 2016

Thanks @mic4ael!

@mic4ael mic4ael deleted the close-button-type branch March 26, 2016 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mic4ael @okcoker @coveralls