Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two IE8 JavaScript bugs #120

Merged
merged 2 commits into from
May 30, 2018
Merged

Fix two IE8 JavaScript bugs #120

merged 2 commits into from
May 30, 2018

Commits on May 29, 2018

  1. Alias HTMLElement->Element in IE8 polyfill

    @zarino
    zarino committed May 29, 2018
    Configuration menu
    Copy the full SHA
    ff7552c View commit details
    Browse the repository at this point in the history

Commits on May 30, 2018

  1. Set Close button type attribute rather than property 

    IE8 does not allow you to change the `type` property of a button after
it has been created (eg: by createElement). But it *does* seem to allow
you to change the `type` *attribute*, which is good enough for our needs
(preventing the parent form from being submitted when the Close button
on a Taggle tag is clicked).
    @zarino
    zarino committed May 30, 2018
    Configuration menu
    Copy the full SHA
    535eb46 View commit details
    Browse the repository at this point in the history