Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSS feed for blog #152

Merged
merged 8 commits into from
Jun 27, 2020
Merged

Add RSS feed for blog #152

merged 8 commits into from
Jun 27, 2020

Conversation

k-nut
Copy link
Member

@k-nut k-nut commented Jun 23, 2020

No description provided.

@ubergesundheit
Copy link
Collaborator

👍 in der alten seite ist der feed im html head folgendermaßen eingebunden

 <link rel="alternate" type="application/rss+xml" title="Blog | Code for Germany" href="/feed.xml">

@k-nut
Copy link
Member Author

k-nut commented Jun 23, 2020

Es sieht mir so aus, als würde das jetzt passen und so aussehen wie vorher. Bitte trotzdem noch mal genau checken :)

@k-nut k-nut marked this pull request as ready for review June 23, 2020 20:19
@ubergesundheit
Copy link
Collaborator

Fehlt noch ein redirect von /feed.xml nach /index.xml. Wenns nativ unter /feed.xml liegen würde wär es noch richtig gut.

Denkst du das kriegst du noch hin? Wenn nicht, dann bitte noch den redirect, dann approve ;)

Copy link
Collaborator

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ein paar Kleinigkeiten

das <pubDate> ist im neuen in UTC, aber das sehe ich nicht als Problem

<channel>
<title>{{ .Site.Title }}</title>
<link>{{ .Permalink }}</link>
<description>Recent content {{ if ne .Title .Site.Title }}{{ with .Title }}in {{.}} {{ end }}{{ end }}on {{ .Site.Title }}</description>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<description>Recent content {{ if ne .Title .Site.Title }}{{ with .Title }}in {{.}} {{ end }}{{ end }}on {{ .Site.Title }}</description>
<description>Stadt<entwickler /> nutzen offene Daten um ihre Stadt zu verbessern</description>

themes/codefor-theme/layouts/index.xml Outdated Show resolved Hide resolved
k-nut and others added 3 commits June 25, 2020 19:21
Co-authored-by: Gerald Pape <ubergesundheit@users.noreply.github.com>
I could not figure out how to create the feed at index.xml
so we use this redirect instead
Copy link
Collaborator

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯 dank

@k-nut k-nut merged commit 4a3c459 into dev Jun 27, 2020
@michael-k michael-k deleted the rss-feed branch June 27, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants