Add Rio de Janeiro/RJ spider #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvinoba
reviewed
May 12, 2018
|
|
||
| return items | ||
|
|
||
| def create_gazette(self, date, url, is_extra_edition = False): |
There was a problem hiding this comment.
Just a small remark: PEP8 recommends no spaces around = sign when indicating default paramater value.
Irio
approved these changes
May 18, 2018
There was a problem hiding this comment.
Just opened an issue to discuss how we've been using Scrapy Contracts. In this case, considering our current patterns, we could just merge this branch without contracts.
Ready to be merged once #28 is on master (working locally).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a spider to crawl gazettes from Rio de Janeiro.
I don't know how to test all possible flows using scrapy contracts.
For example:
no_gazettefor weekends and holidaysone_gazettewhen no extra edition is publishedmultiple_gazettesfor extra editionsI thought about creating 3 functions, one for each case, and write the contract inside each callback function, but it seems overkill, doesn't it?
PS: this PR depends on #28