Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack common tools in a specific module #37

Closed
cuducos opened this issue Sep 3, 2016 · 3 comments
Closed

Pack common tools in a specific module #37

cuducos opened this issue Sep 3, 2016 · 3 comments

Comments

@cuducos
Copy link
Collaborator

cuducos commented Sep 3, 2016

While coding, planning to code or code reviewing I'm starting see a lot of repetition. My intention is to create a new module (tools/ maybe) with tools to be used by anyone in other scripts (setting up scripts from src/, exploring and analyzing data in develop/ etc.).

Anyone is free to join me in this, we can schedule and pair as this has no urgency at all.

And anyone can contribute listing functions that could be inside this module. I get started:

  • list path to the CSV (.xz), i.e. the existing datasets
  • load translations
  • list all record (with or without filters) from the datasets
  • … 
@Irio
Copy link
Collaborator

Irio commented Sep 7, 2016

Been having this need for some time already, but just thought about an issue: Jupyter Notebooks are supposed to be totally reproducible; analyses we have, if ran again, should generate the exact same results. e.g. If I use a function load_dataset('all') in my analysis, its output might change when the function receives a patch.

Personally believe that having these functions will come for the better, even if bringing this issue with them. If we start noticing real problems, we could always use inspect.getsourcelines inside the notebook.

@cuducos
Copy link
Collaborator Author

cuducos commented Sep 11, 2016

@cuducos
Copy link
Collaborator Author

cuducos commented Dec 8, 2016

Fixed by serenata-toolbox (even if we have to actually use it in this repo, as in #143)

@cuducos cuducos closed this as completed Dec 8, 2016
cuducos pushed a commit that referenced this issue Feb 28, 2018
…-module

[WIP] Refactoring rosie to create the core module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants