Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to run django migrations in setup #473

Merged

Conversation

danielSbastos
Copy link
Contributor

@danielSbastos danielSbastos commented May 25, 2019

Hi,
Here we simply add a step in CONTRIBUTING.md to run the project migrations before spinning up the containers.

@cuducos
Copy link
Member

cuducos commented May 25, 2019

Many thanks, but this kind of duplicate this instruction as it is already there a few lines ahead. Any ideas to avoid duplication?

@danielSbastos
Copy link
Contributor Author

danielSbastos commented May 25, 2019

@cuducos, oh, sorry, you're totally right, I must've passed that line while following this guide :/

I'd prefer to leave it here, where I added, because, in my case, after the containers were up, I went to access through the web interface and got an error.

Just a side note, this PR is so small and insignificant, that we could close it, if you'd prefer. I just opened it because I got this error, and thought that other people could have experienced it too, but failed to see that a few lines ahead, the same command was already present.

@cuducos
Copy link
Member

cuducos commented May 25, 2019

I'd prefer to leave it here, where I added, because, in my case, after the containers were up, I went to access through the web interface and got an error.

Totally agree — it makes more sense there. I wouldn't close this PR, just make sure it does not add duplicated instructions ; )

@caiocarrara
Copy link
Contributor

caiocarrara commented May 25, 2019

Hi, guys. Perhaps we can put a note on step Installing mentioning the docker-compose up is just a health check to assure all dependencies are succesfully installed and the project is running well. Even though, to run properly jarbas and rosie there are a few more steps (migrations, for example). So we can put a link to the proper sections: Running Rosie and Running Jarbas.

The step without migration is important to isolate installing error from running migration errors.

@danielSbastos
Copy link
Contributor Author

danielSbastos commented May 25, 2019

@cacarrara, nice! I like your approach and idea. Will do :)

Copy link
Contributor

@caiocarrara caiocarrara left a comment

LGTM 👏

@sergiomario sergiomario merged commit 265ac1c into okfn-brasil:master May 25, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants