-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add step to run django migrations in setup #473
Add step to run django migrations in setup #473
Conversation
Many thanks, but this kind of duplicate this instruction as it is already there a few lines ahead. Any ideas to avoid duplication? |
@cuducos, oh, sorry, you're totally right, I must've passed that line while following this guide :/ I'd prefer to leave it here, where I added, because, in my case, after the containers were up, I went to access through the web interface and got an error. Just a side note, this PR is so small and insignificant, that we could close it, if you'd prefer. I just opened it because I got this error, and thought that other people could have experienced it too, but failed to see that a few lines ahead, the same command was already present. |
Totally agree — it makes more sense there. I wouldn't close this PR, just make sure it does not add duplicated instructions ; ) |
Hi, guys. Perhaps we can put a note on step The step without migration is important to isolate installing error from running migration errors. |
@cacarrara, nice! I like your approach and idea. Will do :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Hi,
Here we simply add a step in
CONTRIBUTING.md
to run the project migrations before spinning up the containers.