Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated changes: typecast, python 3 support, etc. #155

Closed
wants to merge 33 commits into from

Conversation

pudo
Copy link
Contributor

@pudo pudo commented Jul 23, 2016

This changeset supersedes #139, and includes a variety of changes to improve Python 3 support (using six directly).

I expect this to fix #154, #146, #50, #40, #117 and make #37, #140, #148, #149 into issues for typecast.

@pudo
Copy link
Contributor Author

pudo commented Jul 25, 2016

Ok, this is pretty weird: I'm seeing a lot of errors popping up for Python 3 on Travis that aren't there on my local machine. It seems that there's some mismatch that I can't quite put my finger on, plus probably some incompatibilities I introduced with the simplified CSV parser. Would really appreciate any advice, @pwalsh!

@pwalsh
Copy link
Member

pwalsh commented Jul 25, 2016

@pudo ok i'll check it soon. Our CSV (and more) parser at https://github.com/frictionlessdata/tabulator-py should be well and truly on top of Py2/3 issues, FYI :).

@pudo
Copy link
Contributor Author

pudo commented Jul 25, 2016

Interesting. Should we be using that/proxying that? It looks from a first glance like we'd need to add encoding detection etc. -- which is exactly where the weird Py2/3 impedance comes in: https://github.com/frictionlessdata/tabulator-py/blob/master/tabulator/parsers/csv.py#L57

@pwalsh
Copy link
Member

pwalsh commented Jul 25, 2016

@StevenMaude
Copy link
Contributor

StevenMaude commented Oct 4, 2016

@pudo Rebased your branch on master as a new branch, and managed to get Travis to pass on Python 2.7, 3.4 and 3.5. 🎉

It was mostly already there apart from one or two things I changed.

Be nice for me to test it with xypath/databaker; will try take a look at that this week. Would be great to get it merged though as it closes off several issues 👍

@pudo
Copy link
Contributor Author

pudo commented Oct 5, 2016

@StevenMaude wow, that's brilliant. One thing I'd really still like to do before a release is to invert the file type detection, i.e. make file type associations properties of the TableSet classes, rather than in any.py. Once that's done, I think it'd be fair to call this MT2.

@davidread
Copy link
Collaborator

Closed in favour of #171

@davidread davidread closed this Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean type parses values 0 and 1 backwards
4 participants