-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projects page has nice layout and there is filtering #160
Comments
I haven't changed the layout very much, just gave it a tidier look - and added filtering by Featured, Help wanted, Language, Type and Tags. I'm not sure that sorting will be very useful, probably just by last update is good enough for most uses. |
@loleg so looks good so far but think we want further improvements:
I also wonder whether we should display some of this info on projects separate from filter especially, should we somehow badge:
This way even when i'm looking at all projects I know which ones are retired or featured. Lastly: anyway we can get the funky animation that isotope does on its filtering (with stuff moving around) ;-) |
There are currently no featured projects, so the page should be blank. The bug is actually with the initial filter. |
+1. This will work well for ‘featured’, ‘help wanted’ and ‘type’, but perhaps not for ‘tags’ (where there is no predefined set of options to choose from). |
But couldn't you just pull down the complete tag list? For other I was imagine buttons styyle for them all so:
etc |
You can.. it's just quite a lot for a button group. An autocomplete would be better - it's a shame they took typeahead out of bootstrap. |
Take a look at this branch, @rgrp. The javascript is simplified, but the tag and language filters look a bit messy. |
@loleg are you planning to do any more here? |
@loleg I tend to agree. They do add the ability to apply multiple filters, but I’m not convinced that’s so important, and they don’t look good in that branch at present. In terms of UX, rather than using custom styled tabs with selects acting like dropdowns, we could instead use bootstrap dropdowns. Alternatively, I think my preferred option would be to use the “multiple select with groups” bit of Chosen. I’ll have a go at implementing that now. |
@andylolz @loleg - sorry I'd issed the PRs here. I will review the chosen PR but my feeling on use here is that I do want to be able to apply different combinations of filters e.g.
Overall: AND operates across categories and OR within categories @andylolz I get the sense that this proposal is closer to the UX provided by button groupings than the chosen option (?). If so perhaps we should work on improving that. Alternatively we want dropdowns with checkboxes ... (but that may get quite painful ...) |
I hadn’t thought of doing 'or' within categories. That sounds good. The Chosen option already has combinations of filters… The logic just needs changing to do 'or' within categories. |
@andylolz ok - i'm going to merge the chosen PR in right now! |
@andylolz well done, the filtering looks/works wonderful |
@andylolz as mentioned on the PR - one small thing: i think we should immediately update the filtering when someone adds or removes a filter rather than waiting for them to hit "filter" button (i kept waiting for things to change and couldn't understand why nothing was happening!) Other than that I think we could close :-) |
@mchelen work here fixes this i think! |
part of #46
implement
use isotope plus masonry
The text was updated successfully, but these errors were encountered: