Skip to content
This repository has been archived by the owner on Aug 3, 2022. It is now read-only.

Current answers for each question in entry form #792

Closed
brew opened this issue Sep 28, 2016 · 7 comments · Fixed by #824
Closed

Current answers for each question in entry form #792

brew opened this issue Sep 28, 2016 · 7 comments · Fixed by #824
Assignees
Labels
Milestone

Comments

@brew
Copy link
Collaborator

brew commented Sep 28, 2016

If there is an existing current entry, the entry form should show the current values for each question in the entry form.

@brew brew added the design label Sep 28, 2016
@brew brew added this to the Current milestone Sep 28, 2016
@smth
Copy link
Contributor

smth commented Oct 10, 2016

Do old and new answer both need to be visible, or can the existing answer essentially look like a regular one, that has just been entered?

@brew
Copy link
Collaborator Author

brew commented Oct 12, 2016

The old and new answers need to be visible. This allows reviewers to see the current accepted value, and the value being proposed in the submission under review.

@smth
Copy link
Contributor

smth commented Oct 12, 2016

OK, got it. So my next question would be, does this review need to take place within this entry form? Why not have a new page showing some kind of diff view, where you can accept / reject answers?

@brew
Copy link
Collaborator Author

brew commented Oct 12, 2016

I think the previous version allowed reviewers to edit the submission before accepting. So, they'd need the answers to be in a form. It's convenient to reuse the existing entry form for this. Also, submitters themselves also see the current value in the current version as a guide for their submission.

@smth
Copy link
Contributor

smth commented Oct 18, 2016

This is perhaps a discussion for the future. In the mean time I will create a space for existing answers.

Are we able to highlight (add a class to) specific questions that have changed / need reviewing?

@smth
Copy link
Contributor

smth commented Oct 19, 2016

@smth smth closed this as completed Oct 19, 2016
@brew
Copy link
Collaborator Author

brew commented Oct 19, 2016

@smth Don't close the issue please. I still need to implement it!

@brew brew reopened this Oct 19, 2016
@smth smth assigned brew and unassigned smth Oct 19, 2016
brew added a commit that referenced this issue Oct 28, 2016
New submissions and entry review form now displays a current value for
each question, if one exists.
@brew brew closed this as completed in #824 Oct 31, 2016
@brew brew removed the in progress label Oct 31, 2016
@brew brew modified the milestones: Current, Survey 2016 Nov 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants