Skip to content

Commit

Permalink
docs: how to write docs; design decision: plugin dependency (#10)
Browse files Browse the repository at this point in the history
  • Loading branch information
faradox committed Nov 29, 2023
1 parent 748a352 commit c7b05d3
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 12 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ DOCS_SERVE_CMD = mkdir -p htmlcov/ && touch htmlcov/index.html && mkdir -p docs/
POETRY_SETUP_CMD = poetry install --all-extras --sync
POETRY_PUBLISH_CMD = poetry build && poetry publish
CHANGELOG_CMD = git-changelog -c angular -t keepachangelog -s build,deps,feat,fix,refactor,docs -i -o CHANGELOG.md -T --bump=auto .
RELEASE_CMD = git add pyproject.toml CHANGELOG.md && git commit -m "release/$(version)" && git tag $(version) && git push && git push --tags
RELEASE_CMD = git add pyproject.toml CHANGELOG.md && git commit -m "chore: prepare release $(version)" && git tag $(version) && git push && git push --tags

.PHONY: setup setup-test setup-poetry clean format check test docs orm changelog publish release

Expand Down
10 changes: 0 additions & 10 deletions docs/development/documentation.md

This file was deleted.

3 changes: 3 additions & 0 deletions docs/development/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ Different plugin types like analysis, generate, and effect exist because:
- There are shared functionalities within each plugin class provided by Nendo Core.
- These shared functionalities make the implementation of new plugins more effortless for developers.

**Should a plugin depend on or use other plugins?**

We highly advocate against having plugins depend on or use other plugins. The combining of plugins should exclusively happy by means of chaining "from the outside" of Nendo. The reason for this is, that there is a high likelyhood of introducing a dependency conflict if the original project uses say `plugin_a` of a specific version but another plugin, `plugin_b` depends on `plugin_a`, but of another version.

## Writing Good Documentation

Expand Down
1 change: 0 additions & 1 deletion mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ nav:
- Development:
- development/index.md
- Contributing: contributing.md
- Documentation: development/documentation.md
- Plugin Development:
- development/plugindev.md
- Analysis Plugin: development/analysisplugindev.md
Expand Down

0 comments on commit c7b05d3

Please sign in to comment.