sonar reviewed

okjsp · May 24, 2014 · 67512dc · 67512dc
1 parent 4dfbd27
commit 67512dc
Show file tree

Hide file tree

Showing 30 changed files with 128 additions and 138 deletions.
diff --git a/docs/okboard_deleted.sql b/docs/okboard_deleted.sql
@@ -0,0 +1,3 @@
+select count(*) from okboard_deleted where wtime < '2014-05-17';
+
+delete from okboard_deleted where wtime < '2014-05-17';
diff --git a/sonar-project.properties b/sonar-project.properties
@@ -0,0 +1,16 @@
+# Required metadata
+sonar.projectKey=okjsp:site
+sonar.projectName=okjsp-site
+sonar.projectVersion=1.0
+
+# Path to the parent source code directory.
+# Path is relative to the sonar-project.properties file. Replace "\" by "/" on Windows.
+# Since SonarQube 4.2, this property is optional. If not set, SonarQube starts looking for source code
+# from the directory containing the sonar-project.properties file.
+sonar.sources=src
+
+# Encoding of the source code
+sonar.sourceEncoding=ms949
+
+# Additional parameters
+sonar.my.property=value
diff --git a/src/main/java/kr/pe/okjsp/Article.java b/src/main/java/kr/pe/okjsp/Article.java
@@ -519,7 +519,7 @@ public long getSid() {
 					? 0 
 					: Long.parseLong(this.id);
 		} catch (NumberFormatException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 		return sid;
 	}

diff --git a/src/main/java/kr/pe/okjsp/ArticleDao.java b/src/main/java/kr/pe/okjsp/ArticleDao.java
@@ -114,8 +114,6 @@ public Article getArticle(int seq, String sql, Connection conn) throws SQLExcept
 				article.setCcl_id(rs.getString(18));
 			}
 
-		} catch (Exception e) {
-			e.printStackTrace();
 		} finally {
 			dbCon.close(null, pstmt, rs);
 		}
@@ -155,7 +153,7 @@ public int write(Connection conn, Article article) {
 				new PointDao().log(article.getSid(), 2, 10, String.valueOf(article.getSeq()));
 			}
 		} catch (SQLException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(null, pstmt, rs);
 		}
@@ -339,7 +337,7 @@ public void addFile(Connection conn, int seq, ArrayList<DownFile> arrdf)
 				}
 			}
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(null, pstmt);
 		}
@@ -362,7 +360,7 @@ public void deleteFiles(Connection conn, String[] fseqs) {
 				pstmt.executeUpdate();
 			}
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(null, pstmt);
 		}
@@ -396,21 +394,21 @@ public int write(Article article) throws IOException {
 			try {
 				conn.rollback();
 			} catch (SQLException e1) {
-				e1.printStackTrace();
+				System.out.println(e1);
 			}
 			System.out.println("write err: "+e);
 		} catch (IOException e) {
 			try {
 				conn.rollback();
 			} catch (SQLException e1) {
-				e1.printStackTrace();
+				System.out.println(e1);
 			}
 			throw e;
 		} finally {
 			try {
 				conn.setAutoCommit(true);
 			} catch (SQLException e) {
-				e.printStackTrace();
+				System.out.println(e);
 			}
 			dbCon.close(conn, null);
 		}
@@ -435,7 +433,7 @@ public void checkSpam(Connection conn, String bbs, String sid) throws IOExceptio
 			}
 
 		} catch (SQLException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(null, pstmt, rs);
 		}
@@ -460,7 +458,7 @@ public int[] getAdList() {
 			}
 
 		} catch (SQLException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(conn, pstmt, rs);
 		}
@@ -509,17 +507,17 @@ public int delete(long seq) {
 			pstmt.setLong(1, seq);
 			result = pstmt.executeUpdate();
 		} catch (SQLException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			try {
 				pstmt.close();
 			} catch (SQLException e) {
-				e.printStackTrace();
+				System.out.println(e);
 			}
 			try {
 				conn.close();
 			} catch (SQLException e) {
-				e.printStackTrace();
+				System.out.println(e);
 			}
 		}
 		return result;

diff --git a/src/main/java/kr/pe/okjsp/ControllerServlet.java b/src/main/java/kr/pe/okjsp/ControllerServlet.java
@@ -37,13 +37,6 @@ public void init(ServletConfig config) throws ServletException {
 
 	public void doGet(HttpServletRequest req, HttpServletResponse res)
 			throws IOException {
-		String url = req.getRequestURL().toString() + "?"
-				+ req.getQueryString();
-		if (url.toLowerCase().contains("okjsp.pe.kr")) {
-			url = url.replaceAll("okjsp.pe.kr", "okjsp.net");
-			res.sendRedirect(url);
-			return;
-		}
 
 		String act = CommonUtil.nchk(req.getParameter("act"), "VIEW");
 		String resourceName = Navigation.getPath(act);
@@ -112,7 +105,7 @@ public void doGet(HttpServletRequest req, HttpServletResponse res)
 		try {
 			req.getRequestDispatcher(resourceName).forward(req, res);
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 
 	} // end doGet()

diff --git a/src/main/java/kr/pe/okjsp/DeleteServlet.java b/src/main/java/kr/pe/okjsp/DeleteServlet.java
@@ -51,7 +51,7 @@ public void doPost(HttpServletRequest req, HttpServletResponse res)
 		try {
 			seq = Integer.parseInt(req.getParameter("seq"));
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 		/*
 		    db 가져오기
@@ -92,7 +92,7 @@ public void doPost(HttpServletRequest req, HttpServletResponse res)
 					long sid = Long.parseLong(article.getId());
 					new PointDao().log(sid, 3, -50, String.valueOf(article.getSeq()));
 				} catch (Exception e) {
-					e.printStackTrace();
+					System.out.println(e);
 				}
 			} else {
 				resourceName = "/jsp/error.jsp";
@@ -116,7 +116,7 @@ private void doQuery(Connection conn, String query, int seq) throws SQLException
 			pstmt.setInt(1, seq);
 			pstmt.executeUpdate();
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(null, pstmt);
 		}

diff --git a/src/main/java/kr/pe/okjsp/DownloadServlet.java b/src/main/java/kr/pe/okjsp/DownloadServlet.java
@@ -147,7 +147,7 @@ private void countUp(String maskname) {
 			pstmt.executeUpdate();
 			pstmt.close();
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(conn, pstmt);
 		}

diff --git a/src/main/java/kr/pe/okjsp/MemoDao.java b/src/main/java/kr/pe/okjsp/MemoDao.java
@@ -72,7 +72,7 @@ public int write(Connection conn, String id, long sid, String writer, String bco
 				new PointDao().log(sid, 2, 1, String.valueOf(mseq));
 			}
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(null, pstmt, rs);
 		}
@@ -96,10 +96,10 @@ public void setCount(Connection conn, int seq, int memocnt) throws SQLException
 			pstmt.executeUpdate();
 			pstmt.close();
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			try { pstmt.close(); } catch (Exception e2) {
-				e2.printStackTrace();
+				System.out.println(e2);
 			}
 		}
     }
@@ -140,7 +140,7 @@ public int getMemoCount(int seq) {
 			    memocnt = rs.getInt(1);
 
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(conn, pstmt, rs);
 		}

diff --git a/src/main/java/kr/pe/okjsp/ModifyServlet.java b/src/main/java/kr/pe/okjsp/ModifyServlet.java
@@ -84,9 +84,9 @@ public void doPost(HttpServletRequest req, HttpServletResponse res)
 
         req.setAttribute("arrdf", arrdf);
 
-    } catch(Throwable t) {
-        req.setAttribute("javax.servlet.jsp.jspException", t);
-        System.out.println("ModifyServlet err:"+seq+"|"+t.toString());
+    } catch(Exception e) {
+        req.setAttribute("javax.servlet.jsp.jspException", e);
+        System.out.println("ModifyServlet err:"+seq+"|"+e.toString());
     } finally {
 		dbCon.close(conn, pstmt, rs);
     }
@@ -113,7 +113,7 @@ private String getEncryptedString(String confirmPassword, Connection conn) {
 				cryptedString = rs.getString(1);
 			}
 		} catch(Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(null, pstmt, rs);
 		}

diff --git a/src/main/java/kr/pe/okjsp/PopBbsInfoMapServlet.java b/src/main/java/kr/pe/okjsp/PopBbsInfoMapServlet.java
@@ -53,7 +53,7 @@ public void init() {
 			pstmt.close();
 		} catch(Exception e) {
 			System.out.println("can't populate bbsInfoMap due to : "+e.toString());
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(conn, pstmt, rs);
 		} // end try catch

diff --git a/src/main/java/kr/pe/okjsp/ReplyServlet.java b/src/main/java/kr/pe/okjsp/ReplyServlet.java
@@ -21,7 +21,7 @@ public void doGet(HttpServletRequest req, HttpServletResponse res)
     int seq = 0;
     try {
         seq = Integer.parseInt(req.getParameter("seq"));
-    } catch(Exception e) { e.printStackTrace(); }
+    } catch(Exception e) { System.out.println(e); }
 /*
     db 가져오기
 */

diff --git a/src/main/java/kr/pe/okjsp/TagController.java b/src/main/java/kr/pe/okjsp/TagController.java
@@ -17,7 +17,7 @@ protected void doGet(HttpServletRequest req, HttpServletResponse res) throws Ser
 			tagseq = new TagHandler().findTagseqByTag(pathInfo.substring(1));
 			req.getRequestDispatcher("/jsp/taglist.jsp?tagseq="+tagseq).forward(req,res);
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 	}
 }
diff --git a/src/main/java/kr/pe/okjsp/WriteServlet.java b/src/main/java/kr/pe/okjsp/WriteServlet.java
@@ -218,7 +218,7 @@ private void setWriterCookie(String domain, HttpServletResponse res, Article art
 			CommonUtil.setCookie(domain, res, "sid", ""+article.getSid());
 			CommonUtil.setCookie(domain, res, "okhome", ""+article.getHomepage());
 		} catch (UnsupportedEncodingException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 
 	}

diff --git a/src/main/java/kr/pe/okjsp/ad/AdLogDao.java b/src/main/java/kr/pe/okjsp/ad/AdLogDao.java
@@ -27,7 +27,7 @@ public int log(AdLog log) {
 			result = pstmt.executeUpdate();
 
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(conn, pstmt);
 		}

diff --git a/src/main/java/kr/pe/okjsp/member/ArticleDao.java b/src/main/java/kr/pe/okjsp/member/ArticleDao.java
@@ -46,7 +46,7 @@ public List<Article> getArticleListBy(String sid) {
 			}
 
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(conn, pstmt, rs);
 		}

diff --git a/src/main/java/kr/pe/okjsp/member/MemberDao.java b/src/main/java/kr/pe/okjsp/member/MemberDao.java
@@ -58,7 +58,7 @@ public int validateParams(String email, String token) {
 			pstmt.close();
 			rs.close();
 		} catch (SQLException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 		return count;
 	}
@@ -85,7 +85,7 @@ public boolean checkBySid(long sid) {
 					"select count(*) from okmember where sid = ?",
 					new Object[] { sid });
 		} catch (SQLException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 
 		return result == 1;

diff --git a/src/main/java/kr/pe/okjsp/member/MemberService.java b/src/main/java/kr/pe/okjsp/member/MemberService.java
@@ -29,7 +29,6 @@ public String[] sendRecoverPassword(String email) {
 			success = "true";
 			message = email + "로 메일을 발송했습니다.";
 		} catch (Exception e) {
-			e.printStackTrace();
 			System.out.println(e.toString() + "\nfailed: " + email);
 			success = "false";
 			message = email + "로 발송하지 못했습니다.";
@@ -63,7 +62,7 @@ public int changePassword(String email, String password,
 		try {
 			result = dao.setPasswordByEmail(email, password);
 		} catch (SQLException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 		return result;
 	}
@@ -84,7 +83,7 @@ public int changePassword(String email, String password,
 				result = dao.setTokenUsed(token);
 			}
 		} catch (SQLException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 		return result;
 	}
@@ -95,7 +94,7 @@ private boolean isMemberEmail(String email) {
 		try {
 			emailExist = handler.isEmailExist(email);
 		} catch (SQLException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 		return emailExist;
 	}

diff --git a/src/main/java/kr/pe/okjsp/member/PointDao.java b/src/main/java/kr/pe/okjsp/member/PointDao.java
@@ -48,7 +48,7 @@ public int log(long sid, int code, int point, String info) {
 
 			addPoint(conn, sid, point);
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(conn, pstmt);
 		}
@@ -150,7 +150,7 @@ public int deletePoint(long sid) {
 			result = pstmt.executeUpdate();
 
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(conn, pstmt);
 		}

diff --git a/src/main/java/kr/pe/okjsp/member/ProfileUtil.java b/src/main/java/kr/pe/okjsp/member/ProfileUtil.java
@@ -13,9 +13,9 @@ public int copyDefaultProfile(String contextRoot, long sid) {
 		try {
 			result = 1 - copy(sourcePath, destPath);
 		} catch (IOException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} catch (InterruptedException e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 		return result;
 	}

diff --git a/src/main/java/kr/pe/okjsp/mobile/MobileDeleteServlet.java b/src/main/java/kr/pe/okjsp/mobile/MobileDeleteServlet.java
@@ -57,7 +57,7 @@ public void doPost(HttpServletRequest req, HttpServletResponse res)
 		try {
 			seq = Integer.parseInt(req.getParameter("seq"));
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		}
 		/*
 		    db 가져오기
@@ -121,7 +121,7 @@ private void doQuery(Connection conn, String query, int seq) throws SQLException
 			pstmt.setInt(1, seq);
 			pstmt.executeUpdate();
 		} catch (Exception e) {
-			e.printStackTrace();
+			System.out.println(e);
 		} finally {
 			dbCon.close(null, pstmt);
 		}