New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/ulid: use Time helper instead of parsing manually #38

Merged

peterbourgon merged 1 commit into master from use-time-helper

Feb 12, 2019

Member

peterbourgon commented Feb 11, 2019

The code in cmd/ulid/ulid.go pre-dates the ulid.Time helper method, I think.


          cmd/ulid: use Time helper instead of parsing manually

b70a01d

peterbourgon requested a review from tsenart

February 11, 2019 21:26

coveralls commented Feb 11, 2019

Coverage remained the same at 97.938% when pulling b70a01d on use-time-helper into f41f974 on master.

tsenart approved these changes

View reviewed changes

peterbourgon merged commit 2a7d33a into master

peterbourgon deleted the use-time-helper branch

February 12, 2019 00:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet