Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid date format in search_deserializer #38

Closed
hypfvieh opened this issue Apr 20, 2021 · 3 comments
Closed

Invalid date format in search_deserializer #38

hypfvieh opened this issue Apr 20, 2021 · 3 comments

Comments

@hypfvieh
Copy link

When trying your example code with the current 'stable' of your library, I always get an error when the created-date is tried to be read:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ParseError(BadFormat)', /home/hypfvieh/.cargo/registry/src/github.com-1ecc6299db9ec823/musicbrainz_rs-0.3.0/src/deserialization/search_deserializer.rs:148:79

When changing the FORMAT from %Y-%m-%dT%H:%M:%S%.f%Z to %Y-%m-%dT%H:%M:%S%.fZ (not the missing % before 'Z') everything is working fine.
I'm not sure if this is a proper fix, but the current version is unusable because every query for an artist will fail.

@oknozor
Copy link
Owner

oknozor commented Apr 20, 2021

Hey @hypfvieh, thank you for pointing that out. I think I remember fixing that before, might have been reintroduced during a rebase.
Your fix is ok. Since you've done it already do you want to submit a PR or shall I do it ?

@hypfvieh
Copy link
Author

I created a pull request.

@oknozor
Copy link
Owner

oknozor commented May 28, 2021

fixed in #41

@oknozor oknozor closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants