Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement search on entities #69

Merged
merged 10 commits into from
Aug 20, 2021
Merged

Conversation

ritiek
Copy link
Collaborator

@ritiek ritiek commented Aug 1, 2021

Status for all musicbrainz entities that implement search:

  • Area
  • Artist - was previously implemented
  • Event
  • Instrument
  • Label
  • Place - There's some inconsistency in the API response which I reported here. We should probably wait before implementing this and see maybe see if this can be resolved from the musicbrainz side itself otherwise we'll have to workaround this in our library as we currently parse the coordinates as f64 which fails when attempting to use the same coordinate struct to also parse the search response.
  • Recording
  • Release - was previously implemented
  • Release Group - was previously implemented
  • Series
  • Work
  • Annotation
  • Tag - requires http digest authentication which isn't implemented at the moment (e.g. open this while you're logged out of musicbrainz.org). Tag search will need to be implemented once we have authentication up in musicbrainz_rs.
  • CD Stub

Addresses #23.

@ritiek ritiek force-pushed the search-on-entities branch 2 times, most recently from 095b816 to 6a8560e Compare August 11, 2021 16:21
@ritiek ritiek marked this pull request as ready for review August 12, 2021 10:34
@ritiek
Copy link
Collaborator Author

ritiek commented Aug 12, 2021

@oknozor I haven't implemented search on place and tag entities for the reasons mentioned in the PR description, otherwise this should be ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants