[FIX] Ensure valid changes on multi-scroll panes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okonet
requested changes
Jul 18, 2017
src/ScrollSync.js
Outdated
| const { scrollTop, scrollHeight, clientHeight, | ||
| scrollLeft, scrollWidth, clientWidth } = scrolledPane | ||
| const { | ||
| scrollTop, scrollHeight, clientHeight, |
There was a problem hiding this comment.
Can you please put every identifier on a new line?
There was a problem hiding this comment.
Thought its easier to read this way as the properties are grouped by context (...width / ...height) but okay 😉
src/ScrollSync.js
Outdated
| @@ -82,11 +87,11 @@ export default class ScrollSync extends Component { | |||
| const paneHeight = pane.scrollHeight - clientHeight | |||
| const paneWidth = pane.scrollWidth - clientWidth | |||
| /* Adjust the scrollTop position of it accordingly */ | |||
| if (vertical) { | |||
| pane.scrollTop = proportional ? (paneHeight * scrollTop) / (scrollHeight - clientHeight) : scrollTop // eslint-disable-line | |||
| if (vertical && scrollTopOffset) { | |||
There was a problem hiding this comment.
I think && scrollOffset > 0 will be more readable and less ambiguous or what this check is doing?
|
Thanks for the PR! |
|
@okonet Sure. Always glad to find the right tool as you're looking for a solution of a less common problem and the opportunity to contribute back 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
In the current implementation its possible that a division by
0occurs if a sync container has multiple panes with different directions (at least one vertical and one horizontal). In this case some elements have nooverflow-xoroverflow-yvalue but a fixed value. To avoid collision a check is added to ensure only valid results will be set.Furthermore for backwards compatibility the previous
reactversion was added to the peer dependencies.