Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with attrs not being included, add test to detect it #404

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix bug with attrs not being included, add test to detect it #404

merged 1 commit into from
Jan 9, 2020

Conversation

kavigupta
Copy link
Contributor

No description provided.

@aaronchencal aaronchencal self-requested a review January 9, 2020 23:27
aaronchencal
aaronchencal approved these changes Jan 9, 2020
View reviewed changes
Copy link

@aaronchencal aaronchencal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kavigupta kavigupta merged commit 711b7e9 into master Jan 9, 2020
@kavigupta kavigupta deleted the fix-attr-bug branch January 9, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronchencal aaronchencal aaronchencal approved these changes

@Sumukh Sumukh Awaiting requested review from Sumukh

@papajohn papajohn Awaiting requested review from papajohn

@rahularya50 rahularya50 Awaiting requested review from rahularya50

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kavigupta @aaronchencal