Prevent further tests cases from running in case of timeout #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelafox
reviewed
Jan 21, 2022
|
Also requesting review from Vanshaj. |
pamelafox
approved these changes
Jan 21, 2022
itsvs
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, in #459 we made it so that by adding a '# .Case' to each doctest you could make it so that all the doctests are run instead of the default behavior of stopping at the first failed doctest. In the case of infinite loops in student code, this can cause problems because each individual doctest needs to time out leading to a long overall wait time. This PR checks for the first timeout and quits early.