Fix redirects when hosted at a non-root location #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `request.full_path` field does not contain any hosting prefixes as set by `APPLICATION_ROOT` and `SCRIPT_NAME` so redirects fail when the application is not hosted at the root location. Using the `request.url` field instead fixes the redirects. There's a nice comparison of the various request URL parts here: https://stackoverflow.com/a/46176337
Sumukh
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was found by @taupalosaurus.
The
request.full_pathfield does not contain any hosting prefixes asset by
APPLICATION_ROOTandSCRIPT_NAMEso redirects fail when theapplication is not hosted at the root location. Using the
request.urlfield instead fixes the redirects. There's a nice comparison of the
various request URL parts here: https://stackoverflow.com/a/46176337