-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't auto remediate SelectAuthenticator with current authenticator #1426
Merged
eng-services-aperture-github-bot-okta
merged 10 commits into
7.3
from
od-fix-auto-remediation-current-authenticator-OKTA-612939
Jul 18, 2023
Merged
fix: Don't auto remediate SelectAuthenticator with current authenticator #1426
eng-services-aperture-github-bot-okta
merged 10 commits into
7.3
from
od-fix-auto-remediation-current-authenticator-OKTA-612939
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b19963
to
c5af40c
Compare
f61a67a
to
875791e
Compare
7dcadb2
to
0b2f16f
Compare
6813bec
to
5f3a51f
Compare
jaredperreault-okta
approved these changes
Jul 18, 2023
baf5d13
to
5f3a51f
Compare
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Don't auto remediate
select-authenticator-authenticate
/select-authenticator-enroll
if authenticator has been already selected (currentAuthenticatorEnrollment
/currentAuthenticator
is present in IDX response)Note:
currentAuthenticator
is used during enrollment,currentAuthenticatorEnrollment
during verify flow. Both means the same, naming is confusing.Internal ref: OKTA-612939, OKTA-609234