feat: Adds pass-thru of optional 'loginHint' and 'idpScopes' params #238
Conversation
| @@ -271,22 +271,26 @@ function convertOAuthParamsToQueryParams(oauthParams) { | |||
| // Convert our params to their actual OAuth equivalents | |||
| var oauthQueryParams = util.removeNils({ | |||
There was a problem hiding this comment.
This list was getting long, and to make it easier to compare to the docs I sorted it. Unfortunately this means updating all the unit tests that specified the expected order.
Params are now in alphabetical order except for scope, which is always last.
| }); | ||
| }); | ||
|
|
||
| it('passes optional login_hint query param through', function() { |
There was a problem hiding this comment.
Here and below are the new tests.
Note there is no update to README because the README already doesn't document the optional params, instead referring to the API docs, so I followed that trend.
| }); | ||
| }); | ||
|
|
||
| it('passes optional idp_scope query param through when given a string', function() { |
There was a problem hiding this comment.
idp_scope/idpScope probably only makes sense if the idp param is also passed, but didn't see anything specific in the docs and left out any enforcement - we pass to the backend and let it react if it wants.
No description provided.