New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for popup blocker #265

Merged

aarongranick-okta merged 1 commit into master from ag-popup-OKTA-241769

Nov 7, 2019

Contributor

aarongranick-okta commented Nov 6, 2019 •

edited

Loading

behavior is seen on firefox, not chrome. Popup blocker leaves us with an "undefined" window object
fix potential infinite loop with closePoller() - polling will stop as soon as window is closed or promise is resolved. The promise should only reject one time.
add test for popup block case
add test for popup timeout

Fixes: #221


          Fix for popup blocker

b30a9af

aarongranick-okta mentioned this pull request

fix: Token issue if popup blocker present #221 #222

Closed

aarongranick-okta requested a review from swiftone

November 7, 2019 00:02

swiftone approved these changes

View reviewed changes

aarongranick-okta merged commit e26be85 into master

aarongranick-okta deleted the ag-popup-OKTA-241769 branch

November 7, 2019 19:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet