-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support relative redirect uri - OKTA-324356 #503
feat: support relative redirect uri - OKTA-324356 #503
Conversation
test/spec/util.js
Outdated
expect(util.toAbsoluteUrl(url, baseUrl)).toEqual('http://fake.com/relative'); | ||
}); | ||
|
||
it('should return correct url when relative url without "/" and baseurl with trialing "/"', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "trailing"
test/spec/util.js
Outdated
expect(util.toAbsoluteUrl(url, baseUrl)).toEqual('http://fake.com/relative'); | ||
}); | ||
|
||
it('should return correct url when baseUrl has trialing "/"', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "trailing"
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 90.47% 90.83% +0.36%
==========================================
Files 31 33 +2
Lines 1574 1767 +193
Branches 344 391 +47
==========================================
+ Hits 1424 1605 +181
- Misses 150 162 +12
Continue to review full report at Codecov.
|
resolves: okta/okta-vue#19