Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect error and error_description in redirect uri #583

Closed
wants to merge 2 commits into from

Conversation

aarongranick-okta
Copy link
Contributor

  • isLoginRedirect will now return true when there is an error and error_description in the redirect uri
  • adds test for OAuthError from parseFromUrl which encapsulates this error from the backend

@aarongranick-okta aarongranick-okta changed the base branch from 4.5 to master January 7, 2021 23:32
@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #583 (ff58d51) into master (3fdc52e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   92.96%   92.98%   +0.01%     
==========================================
  Files          38       38              
  Lines        2161     2167       +6     
  Branches      452      454       +2     
==========================================
+ Hits         2009     2015       +6     
  Misses        152      152              
Impacted Files Coverage Δ
lib/oauthUtil.ts 98.54% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fdc52e...ff58d51. Read the comment docs.

@aarongranick-okta
Copy link
Contributor Author

@shuowu see CHANGELOG. I am targeting the change for next minor version release. Although it can definitely be considered a bug fix, there is also the possibility that any change in the result from isLoginRedirect may change app behavior in large ways. So I think it's safer to put on minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants