#768 Moves atob from devDependencies to dependencies #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes in 5.x appear to have made atob a runtime dependency, leading to a runtime error when importing the okta-auth-js library.
Codecov Report
@@ Coverage Diff @@
## 5.0 #786 +/- ##
=======================================
Coverage 82.23% 82.23%
=======================================
Files 100 100
Lines 2916 2916
Branches 590 590
=======================================
Hits 2398 2398
Misses 518 518 Continue to review full report at Codecov.
|
oleksandrpravosudko-okta
approved these changes
Jun 3, 2021
|
@hirako2000 Thanks for your contribution! The issue is handled in #805. Close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in 5.x appear to have made atob a runtime dependency, leading to a runtime error when importing the okta-auth-js library.