chore: move crypto related modules to deps - OKTA-402553 #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrpravosudko-okta
approved these changes
Jun 8, 2021
aarongranick-okta
approved these changes
Jun 8, 2021
shuowu-okta
force-pushed
the
sw-move-crypto-modules-to-deps-OKTA-402553
branch
from
70cccb9
to
70b84c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 114 114
Lines 3267 3267
Branches 679 679
=======================================
Hits 2996 2996
Misses 271 271 Continue to review full report at Codecov.
|
|
🙌 |
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Jun 8, 2021
OKTA-402553 <<<Jenkins Check-In of Tested SHA: 70b84c3 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 2 PR Link: "#805"
shuowu-okta
pushed a commit
that referenced
this pull request
Jun 8, 2021
OKTA-402553 <<<Jenkins Check-In of Tested SHA: 70b84c3 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 2 PR Link: "#805"
shuowu-okta
pushed a commit
that referenced
this pull request
Jun 8, 2021
OKTA-402553 <<<Jenkins Check-In of Tested SHA: 70b84c3 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 2 PR Link: "#805"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommonJS bundle need to use crypto related modules from
dependencies. This change moves modules fromdevDepstodeps.Resolves: #768