Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct parseFromUrl signature in type definitions (#763 copy) #853

Closed

Conversation

oleksandrpravosudko-okta
Copy link
Contributor

Copy of #763 for internal CI

@oleksandrpravosudko-okta oleksandrpravosudko-okta force-pushed the op-okta-407714-parsefromurl-signature branch from 9fecf31 to 5387771 Compare July 6, 2021 14:39
Copy link
Contributor

@shuowu-okta shuowu-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #853 (4cf51e3) into master (9e5b981) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files         116      116           
  Lines        3354     3354           
  Branches      695      695           
=======================================
  Hits         3066     3066           
  Misses        288      288           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5b981...4cf51e3. Read the comment docs.

FelixSchwarzmeier and others added 2 commits July 7, 2021 14:05
@oleksandrpravosudko-okta oleksandrpravosudko-okta force-pushed the op-okta-407714-parsefromurl-signature branch from bbe8618 to 3ba40b9 Compare July 7, 2021 11:08
@oleksandrpravosudko-okta oleksandrpravosudko-okta force-pushed the op-okta-407714-parsefromurl-signature branch from 3ba40b9 to 4cf51e3 Compare July 7, 2021 11:12
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Jul 7, 2021
Fix ParseFromUrlFunction parameter type
chore: add signature test for parseFromUrl
doc: `token.parseFromUrl` changelog entry

OKTA-407714
<<<Jenkins Check-In of Tested SHA: 4cf51e3 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 3
PR Link: "#853"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants