Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verify token using issuer from .well-known endpoint #858

Closed
wants to merge 2 commits into from

Conversation

aarongranick-okta
Copy link
Contributor

  • also fixes duplicate "add" event fired from updating rotating refresh token
  • adds a proxy to test/app e2e and proxy specs

Object.assign(validationOptions, validationParams);
}, validationParams, {
// final options, cannot be overridden
issuer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

Merging #858 (b9187d0) into 5.2 (c6da2e1) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head b9187d0 differs from pull request most recent head feb03b9. Consider uploading reports for the commit feb03b9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              5.2     #858      +/-   ##
==========================================
+ Coverage   91.35%   91.44%   +0.08%     
==========================================
  Files         116      116              
  Lines        3333     3330       -3     
  Branches      691      692       +1     
==========================================
  Hits         3045     3045              
+ Misses        288      285       -3     
Impacted Files Coverage Δ
lib/oidc/util/refreshToken.ts 91.66% <ø> (+10.71%) ⬆️
lib/TokenManager.ts 94.53% <100.00%> (+0.14%) ⬆️
lib/oidc/renewTokensWithRefresh.ts 100.00% <100.00%> (ø)
lib/oidc/verifyToken.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6da2e1...feb03b9. Read the comment docs.

avoid emitting an "add" event when rotating refresh token is added.

add e2e tests for proxy and token renew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants