Use /.well-known/openid-configuration issuer attribute for id_token validation #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a proxy to be used with Okta.
This comment no longer applies to this implementation.
|
@JamesParkinSonos Thanks for the PR! While our team is reviewing the PR, can you please sign and submit a CLA for us? https://developer.okta.com/cla/ |
|
Thanks @shuowu. I've signed and emailed the CLA. |
|
Internal Ref: OKTA-412050 |
|
@JamesParkinSonos I just figured out the issue is actually handled by one of our internal PR (#858). Thanks again for your contribution! Close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is based on a previous pull request made by @scottirvinsonos (#555), however, his implementation seems to have been lost when the code was refactored.
Other Okta SDK's use the issuer URL found in the /.well-known/openid-configuration response body when validating the id_token. This SDK currently uses the URL specified in the config object passed to the constructor at the time the OAuth client object is instantiated. This is not desirable as it makes it impossible to use a proxy with Okta.
The change made uses the issuer attribute found in the /.well-known/openid-configuration response body and compares it to the issuer claim in the id_token to validate the token.