Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signInWithCredential MFA cookie issue #893

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Aug 5, 2021

This PR:

  • fixes missing {withCredential: true} when call signInWithCredential method
  • adds a React MFA (v1) sample under /samples folder, the sample supports Email and Security question factors
  • adds mfa-password-and-question cucumber feature to verify the SDK change against e2e
  • updates SIW to the latest version in repo

@shuowu-okta shuowu-okta force-pushed the sw-fix-signInWithCredential-request-header-OKTA-415464 branch from 6daa4c2 to 5d9e5aa Compare August 10, 2021 17:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #893 (b846896) into 5.3 (a4bb17a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##              5.3     #893    +/-   ##
========================================
  Coverage   91.58%   91.59%            
========================================
  Files         120      120            
  Lines        3375     3497   +122     
  Branches      695      734    +39     
========================================
+ Hits         3091     3203   +112     
- Misses        284      294    +10     
Impacted Files Coverage Δ
lib/OktaAuth.ts 89.70% <100.00%> (+0.94%) ⬆️
lib/tx/AuthTransaction.ts 89.71% <100.00%> (ø)
lib/idx/index.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bb17a...b846896. Read the comment docs.

@shuowu-okta shuowu-okta changed the base branch from master to 5.3 August 11, 2021 15:31
@shuowu-okta shuowu-okta force-pushed the sw-fix-signInWithCredential-request-header-OKTA-415464 branch from 90b0688 to b846896 Compare August 11, 2021 15:53
Copy link
Contributor

@aarongranick-okta aarongranick-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If version bump is included in this PR, would be best to squash everything, but leave version bump (and changelog if you want) in its own commit (the last before we promote), so it will have an extra entry in the commit history and we will see it in master after the backport merge.

@shuowu-okta shuowu-okta force-pushed the sw-fix-signInWithCredential-request-header-OKTA-415464 branch from 35d8fbb to f7af460 Compare August 11, 2021 23:14
@shuowu shuowu merged commit 4f5b3bd into 5.3 Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants