fixes issue with renewTokens that would drop scopes passed to getToken #985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #942
scopes can be passed in the constructor or into the getToken function (getWithRedirect, getWithoutPrompt, etc.). The scopes are saved with the token and are passed along when renewing a single token or renewing using a refresh token. However when all tokens are renewed together (default action when
autoRenew
is true), the scopes passed to getToken were being dropped and the scopes passed in constructor were used instead.To reproduce the issue clearly, some "integration" tests which run against a live environment but are not using a test app or a web browser. Rewrite unit tests for
renewTokens
to cover the specific logic of this function. The previous unit tests (oauthUtil.setupFrame) are superseded by the new integration tests.OKTA-429429