This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
fix: Updates for internal CI scripts #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmelberg-okta
approved these changes
Aug 7, 2018
scripts/setup.sh
Outdated
| @@ -1,5 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| export PATH="${PATH}:$(yarn global bin)" | |||
There was a problem hiding this comment.
Lets make sure we add a comment to be consistent with what we've done in other repos. We should be indicating why this line is required.
# Add yarn to the $PATH so cli commands do not fail
export PATH="${PATH}:$(yarn global bin)"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setup.shscript was failing to find globally installed NPM modules. Applying the workarounds we've used elsewhere.