This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
feat(jwt-verifier): Removes check of client_id from access tokens #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertjd
reviewed
Jun 17, 2019
| @@ -95,22 +94,14 @@ describe('jwt-verifier configuration validation', () => { | |||
| expect(createInstance).toThrow(); | |||
| }); | |||
|
|
|||
| it('should throw if the client_id is not provided', () => { | |||
| it('should NOT throw if client_id not matching {clientId} is provided', () => { | |||
There was a problem hiding this comment.
What is this testing? That we don't throw if they provide a client_id?
There was a problem hiding this comment.
Asserting that the input is allowed, and is NOT checked against the claims automatically.
That's not exciting, but this documents the expected behavior for this case.
| @@ -63,9 +63,10 @@ class OktaJwtVerifier { | |||
| constructor(options = {}) { | |||
| // Assert configuration | |||
| assertIssuer(options.issuer, options.testing); | |||
| assertClientId(options.clientId); | |||
| if( options.clientId ) { | |||
There was a problem hiding this comment.
Do we even need assertClientId anymore? Or should we just let this be handled by the custom claims assertion logic?
There was a problem hiding this comment.
The value here is catching "{clientId}" cases.
assertClientId doesn't validate the claim, it checks for a well-formed and present clientId.
robertjd
approved these changes
Jun 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
clientId/client_id was required, even for access tokens that, per spec, do not require client id
Issue Number: #367
What is the new behavior?
clientId is now optional, and will only be asserted if such an assertion is requested via customClaims
Does this PR introduce a breaking change?
Other information
Reviewers
@aarongranick-okta