Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

fix(jwt-verifier): Updates dev deps to remove vulns #484

Merged
merged 2 commits into from
Jun 27, 2019

Conversation

swiftone
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

npm audit/ synk complain about vulns in dependencies via jest/jest-junit

Issue Number: N/A

What is the new behavior?

Packages updated in the devdeps list

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Done in prep of new npm publish

Reviewers

yarn.lock Outdated
@@ -8936,7 +8712,6 @@ node-pre-gyp@^0.12.0:
node-releases@^1.1.23:
version "1.1.23"
resolved "https://registry.yarnpkg.com/node-releases/-/node-releases-1.1.23.tgz#de7409f72de044a2fa59c097f436ba89c39997f0"
integrity sha512-uq1iL79YjfYC0WXoHbC/z28q/9pOl8kSHaXdWmAAc8No+bDwqkZbzIJz55g/MUsPgSGm9LZ7QSUbzTcH5tz47w==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticing that all the integrity hashes are leaving.Is this expected? How are your local npm settings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Looks like a yarn downgrade on my side, updating to latest yarn fixed it.

@swiftone swiftone merged commit 0d5afa7 into master Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants