Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blacklist vkbeautify #497

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Blacklist vkbeautify #497

merged 1 commit into from
Jul 13, 2018

Conversation

jmelberg-okta
Copy link
Contributor

@jmelberg-okta jmelberg-okta commented Jul 11, 2018 •
edited
Loading

Description

@jmelberg-okta jmelberg-okta force-pushed the jm-blacklist branch 3 times, most recently from c556c98 to 28486b3 Compare July 11, 2018 22:50
nikhilvenkatraman-okta
nikhilvenkatraman-okta reviewed Jul 11, 2018
View reviewed changes
Copy link
Contributor

@nikhilvenkatraman-okta nikhilvenkatraman-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove /vendor\/plugins\/vkbeautify/ on line 89 ? I see that you are also removing few other outdated deps. Curious if we should we make those changes in a different PR?

@jmelberg-okta jmelberg-okta force-pushed the jm-blacklist branch 2 times, most recently from 0025ac5 to 1291b24 Compare July 13, 2018 20:00
@jmelberg-okta jmelberg-okta mentioned this pull request Jul 13, 2018
Closed
nikhilvenkatraman-okta
nikhilvenkatraman-okta approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@nikhilvenkatraman-okta nikhilvenkatraman-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jmelberg-okta jmelberg-okta merged commit 4f73a15 into master Jul 13, 2018
@jmelberg-okta jmelberg-okta deleted the jm-blacklist branch July 13, 2018 23:04
jmelberg-okta added a commit that referenced this pull request Jul 16, 2018
@jmelberg-okta
Blacklist modules (#497)
d649420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilvenkatraman-okta nikhilvenkatraman-okta nikhilvenkatraman-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmelberg-okta @nikhilvenkatraman-okta