Shell arg fix #380
Merged
Shell arg fix #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes first param from arg lists before calling aws cli. Fixes both bash and fish Resolves: oktadev#375, oktadev#376
changing oktadeveloper to oktadev
🐛 Fixes shell arguments being passed twice to aws command
…/okta-aws-cli-assume-role into DavidTanner-updateInstallScripts
|
replaces #378 @hcourse-nydig @DavidTanner please confirm that this looks good. I basically took both of your solutions and combined them. Also sorry, not sure if there's a way to modify an existing PR, so created a new one. |
DavidTanner
suggested changes
Aug 4, 2021
bin/install.sh
Outdated
| @@ -111,12 +111,14 @@ fishFunctionsDir="${PREFIX}/fish_functions" | |||
| mkdir -p "${fishFunctionsDir}" | |||
| cat <<'EOF' >"${fishFunctionsDir}/okta-aws.fish" | |||
| function okta-aws | |||
| withokta "aws --profile $argv[1]" $argv | |||
| set -lx OKTA_PROFILE "$argv[1]" | |||
| OKTA_PROFILE="$1" withokta "aws --profile $argv[1]" $argv[2..-1] | |||
There was a problem hiding this comment.
Same as below. Doesn't work the same in fish as bash.
added 2 commits
August 4, 2021 16:02
…ume-role into shell-arg-fix
|
@mraible what stands in the way of getting this merged in? |
|
@dangeReis Nothing. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Updating the withOkta script to not use the profile broke the okta-aws and okta-sls commands.
Solution
Set the profile in the respective commands. Also remove the profile from the arguments being passed in to aws cli (or sls cli). Additionally this stores the appropriate profile name in the .aws/credentials file.
This should fix #374 #375 #376