Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven with fixes #9

Closed
wants to merge 2 commits into from
Closed

Maven with fixes #9

wants to merge 2 commits into from

Conversation

radekg
Copy link

@radekg radekg commented Nov 11, 2016

Description of the changes:

  • remove .idea and *.iml files from github, these should not be in the repository
  • changes configuration from properties to Typesafe Config
  • adds support for role selection using aws.role, do not force selection every single time the program is executed
  • removes OKTA_ORG setting, org now inferred from app_url
  • allows customizing the credential profile with aws.credential_profile
  • Maven, no need for the manual setup anymore
  • removes hand written ~/.aws/config and ~/.aws/credentials parsers / updates with an ini file handling library (as those files are actually ini files)

RFC.

@radekg
Copy link
Author

radekg commented Nov 11, 2016

There's so much more things that could be improved here. This is just a first batch.

@jpf
Copy link

jpf commented Nov 11, 2016

Thanks for the PR! We'll be looking at this soon.

@radekg radekg mentioned this pull request Nov 11, 2016
@radekg
Copy link
Author

radekg commented Nov 12, 2016

Due to issues with the CLA, I'm forced to close this pull request.

@radekg radekg closed this Nov 12, 2016
AlainODea pushed a commit that referenced this pull request Oct 5, 2018
…rsion

⬆️ Bump aws-java-sdk.version from 1.11.407 to 1.11.408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants