Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use updated API method from main generator to load configs #69

Closed
wants to merge 4 commits into from
Closed

Use updated API method from main generator to load configs #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db4224e
Use updated API method from main generator
pmverma May 15, 2019
44a097b
fix failing build by using latest version of main generator
pmverma May 15, 2019
4882a9b
update jhipster version to pass the build
pmverma May 15, 2019
01aae3d
updated starter template url
pmverma May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions generators/app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ module.exports = class extends BaseGenerator {
}
},
readConfig() {
this.jhipsterAppConfig = this.getJhipsterAppConfig();
this.jhipsterAppConfig = this.getAllJhipsterConfig();
},
displayLogo() {
// it's here to show that you can use functions from generator-jhipster
Expand Down Expand Up @@ -129,9 +129,9 @@ module.exports = class extends BaseGenerator {
this.error(`\nYour backend project must be a monolith or a gateway to work with this module! Found application type: ${applicationType}.\n`);
}

const cmd = `ionic start ${this.ionicAppName} oktadeveloper/jhipster${(this.interactive) ? '' : ' --no-interactive'}`;
const cmd = `ionic start ${this.ionicAppName} https://github.com/oktadeveloper/ionic-jhipster-starter${(this.interactive) ? '' : ' --no-interactive'}`;
Copy link

@fleboulch fleboulch May 17, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmverma
The support for V4 is still not finished. We need to add entity support as V3 does.
So this change can't be added right now.
To fix this you can run the ionic start command with the flag --type=ionic-angular for Ionic v4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fleboulch. I am going to close this PR as I notice v4 support is already in progress.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will go to try this..

this.log(`\nCreating Ionic app with command: ${chalk.green(`${cmd}`)}`);
const params = ['start', this.ionicAppName, 'oktadeveloper/jhipster'];
const params = ['start', this.ionicAppName, 'https://github.com/oktadeveloper/ionic-jhipster-starter'];
if (!this.interactive) {
params.push('--no-interactive');
params.push('--quiet');
Expand Down