-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use updated API method from main generator to load configs #69
Conversation
Getting following error.
|
I think build error is due to v4. |
See #68 (comment) This module only works with Ionic 3 and JHipster 5. We’re working on a version that works with Ionic 4 and JHipster 6. We have to get the starter integrated first. Follow ionic-team/starters#749 to see when that is complete. |
Thanks @mraible |
@@ -129,9 +129,9 @@ module.exports = class extends BaseGenerator { | |||
this.error(`\nYour backend project must be a monolith or a gateway to work with this module! Found application type: ${applicationType}.\n`); | |||
} | |||
|
|||
const cmd = `ionic start ${this.ionicAppName} oktadeveloper/jhipster${(this.interactive) ? '' : ' --no-interactive'}`; | |||
const cmd = `ionic start ${this.ionicAppName} https://github.com/oktadeveloper/ionic-jhipster-starter${(this.interactive) ? '' : ' --no-interactive'}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmverma
The support for V4 is still not finished. We need to add entity support as V3 does.
So this change can't be added right now.
To fix this you can run the ionic start command with the flag --type=ionic-angular
for Ionic v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fleboulch. I am going to close this PR as I notice v4 support is already in progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will go to try this..
Fix #68