Skip to content

Commit

Permalink
fix: stack deploy is showing endpoints when fail (#2310)
Browse files Browse the repository at this point in the history
* fix: stack deploy is showing endpoints when fail

Signed-off-by: Javier López Barba <javier@okteto.com>

* refactor: rewrite error

Signed-off-by: Javier López Barba <javier@okteto.com>
  • Loading branch information
jLopezbarb committed Mar 4, 2022
1 parent e27ade8 commit 0105251
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions cmd/stack/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,10 @@ func (c *DeployCommand) RunDeploy(ctx context.Context, s *model.Stack, options *
err := stackDeployer.Deploy(ctx, s, options)

analytics.TrackDeployStack(err == nil, s.IsCompose, utils.IsOktetoRepo())
if err == nil {
oktetoLog.Success("Compose '%s' successfully deployed", s.Name)
if err != nil {
return err
}
oktetoLog.Success("Compose '%s' successfully deployed", s.Name)

if !utils.LoadBoolean(model.OktetoWithinDeployCommandContextEnvVar) || !c.IsInsideDeploy {
if err := stack.ListEndpoints(ctx, s, ""); err != nil {
Expand Down

0 comments on commit 0105251

Please sign in to comment.