refactor: remove unused namespace param

Signed-off-by: Teresa Romero <teresa@okteto.com>
okteto · Nov 11, 2021 · 18c7b8e · 18c7b8e
1 parent 955d560
commit 18c7b8e
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/cmd/build.go b/cmd/build.go
@@ -66,7 +66,7 @@ func Build(ctx context.Context) *cobra.Command {
 			}
 
 			ctx := context.Background()
-			if err := build.Run(ctx, "", options); err != nil {
+			if err := build.Run(ctx, options); err != nil {
 				analytics.TrackBuild(okteto.Context().Builder, false)
 				return err
 			}

diff --git a/cmd/push.go b/cmd/push.go
@@ -273,7 +273,7 @@ func buildImage(ctx context.Context, dev *model.Dev, imageTag, imageFromApp, okt
 		BuildArgs:  buildArgs,
 		OutputMode: progress,
 	}
-	if err := build.Run(ctx, dev.Namespace, buildOptions); err != nil {
+	if err := build.Run(ctx, buildOptions); err != nil {
 		return "", err
 	}
 

diff --git a/cmd/up/up.go b/cmd/up/up.go
@@ -408,7 +408,7 @@ func (up *upContext) buildDevImage(ctx context.Context, app apps.App) error {
 		BuildArgs:  buildArgs,
 		OutputMode: "tty",
 	}
-	if err := buildCMD.Run(ctx, up.Dev.Namespace, buildOptions); err != nil {
+	if err := buildCMD.Run(ctx, buildOptions); err != nil {
 		return err
 	}
 	for _, s := range up.Dev.Services {

diff --git a/pkg/cmd/build/build.go b/pkg/cmd/build/build.go
@@ -43,20 +43,20 @@ type BuildOptions struct {
 }
 
 // Run runs the build sequence
-func Run(ctx context.Context, namespace string, buildOptions BuildOptions) error {
+func Run(ctx context.Context, buildOptions BuildOptions) error {
 	if okteto.Context().Builder == "" {
 		if err := buildWithDocker(ctx, buildOptions); err != nil {
 			return err
 		}
 	} else {
-		if err := buildWithOkteto(ctx, namespace, buildOptions); err != nil {
+		if err := buildWithOkteto(ctx, buildOptions); err != nil {
 			return err
 		}
 	}
 	return nil
 }
 
-func buildWithOkteto(ctx context.Context, namespace string, buildOptions BuildOptions) error {
+func buildWithOkteto(ctx context.Context, buildOptions BuildOptions) error {
 	log.Infof("building your image on %s", okteto.Context().Builder)
 	buildkitClient, err := getBuildkitClient(ctx)
 	if err != nil {

diff --git a/pkg/cmd/stack/translate.go b/pkg/cmd/stack/translate.go
@@ -173,7 +173,7 @@ func buildServices(ctx context.Context, s *model.Stack, options *StackDeployOpti
 			BuildArgs:  buildArgs,
 			OutputMode: options.Progress,
 		}
-		if err := build.Run(ctx, s.Namespace, buildOptions); err != nil {
+		if err := build.Run(ctx, buildOptions); err != nil {
 			return hasBuiltSomething, err
 		}
 		svc.SetLastBuiltAnnotation()
@@ -219,7 +219,7 @@ func addVolumeMountsToBuiltImage(ctx context.Context, s *model.Stack, options *S
 				BuildArgs:  buildArgs,
 				OutputMode: options.Progress,
 			}
-			if err := build.Run(ctx, s.Namespace, buildOptions); err != nil {
+			if err := build.Run(ctx, buildOptions); err != nil {
 				return hasAddedAnyVolumeMounts, err
 			}
 			svc.SetLastBuiltAnnotation()