fix: validate dev only when you have selected which one you want to d…

…evelop in (#2330)

Signed-off-by: Javier López Barba <javier@okteto.com>

cmd/utils/dev.go

@@ -188,6 +188,10 @@ func GetDevFromManifest(manifest *model.Manifest, devName string) (*model.Dev, e
 		return nil, err
 	}
 
+	if err := manifest.Dev[devKey].Validate(); err != nil {
+		return nil, err
+	}
+
 	return manifest.Dev[devKey], nil
 }
 

cmd/utils/displayer/tty.go

@@ -342,7 +342,13 @@ func renderLines(queue []string, charsPerLine int) [][]byte {
 
 func renderLogWithColors(tpl *template.Template, line string, charsPerLine int) [][]byte {
 	result := [][]byte{}
-	result = append(result, render(tpl, fmt.Sprintf("%s...", line[:charsPerLine-5])))
+	if charsPerLine > 4 && len(line)+2 > charsPerLine {
+		result = append(result, render(tpl, fmt.Sprintf("%s...", line[:charsPerLine-5])))
+	} else if line == "" {
+		result = append(result, []byte(""))
+	} else {
+		result = append(result, render(tpl, line))
+	}
 	return result
 }
 

pkg/model/dev.go

@@ -295,10 +295,6 @@ func Get(devPath string) (*Manifest, error) {
 			return nil, err
 		}
 
-		if err := dev.validate(); err != nil {
-			return nil, err
-		}
-
 		dev.computeParentSyncFolder()
 	}
 
@@ -649,7 +645,8 @@ func (dev *Dev) expandEnvFiles() error {
 	return nil
 }
 
-func (dev *Dev) validate() error {
+// Validate validates if a dev environment is correctly formed
+func (dev *Dev) Validate() error {
 	if dev.Name == "" {
 		return fmt.Errorf("Name cannot be empty")
 	}

pkg/model/dev_test.go

@@ -522,7 +522,7 @@ func TestDev_validateName(t *testing.T) {
 			if err := dev.SetDefaults(); err != nil {
 				t.Fatalf("error applying defaults: %v", err)
 			}
-			if err := dev.validate(); (err != nil) != tt.wantErr {
+			if err := dev.Validate(); (err != nil) != tt.wantErr {
 				t.Errorf("Dev.validate() error = %v, wantErr %v", err, tt.wantErr)
 			}
 		})
@@ -989,7 +989,7 @@ func Test_validate(t *testing.T) {
 
 			dev := manifest.Dev["deployment"]
 
-			err = dev.validate()
+			err = dev.Validate()
 			if tt.expectErr && err == nil {
 				t.Error("didn't get the expected error")
 			}

pkg/model/manifest.go

@@ -383,10 +383,6 @@ func getManifest(devPath string) (*Manifest, error) {
 			return nil, err
 		}
 
-		if err := dev.validate(); err != nil {
-			return nil, err
-		}
-
 		dev.computeParentSyncFolder()
 	}